Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace <article class="card"> with the main tag and <h3> with <h1> to make the content/page accessible. click here for more on web-accessibility and semantic html
Give the alt attribute in the img a value. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.
Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
Give h1 and p text-align: center, the same margin-left, margin-right and margin-top values. .
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@sarahsoaressilvaPosted over 1 year ago@Hassiai, thank you for the comments!
I used article, since this is a reusable and independent component. If I use main tag instead of article, this can no longer be used on other places, because could conflict with others main tags. I followed the same logic with h3.
About the alt atributte, thank you for the advice, I added on the new version of this code.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord