QR code component

Community feedback

• 

  Felipe Salazar•140

  @andressalazar08Posted almost 2 years ago

  Hi Simone,

  Great Solution, I also addresses this challenge and I would like to suggest some things that you can check.

  -Follow the recommendation to customize the Readme on your github. In this way you will ensure that those who visit your github can understand what the project is about.

  -Check the warnings. One of them refers to the image. All images must have an alt="" to describe it in case browsers can't render it. It also helps the positioning and description of your site for screen readers.

  -Use the length units in the relative way. Try to use rem, it has a default correspondence with pixels 1rem == 16px. If you need to make a change to the default value, you can do it from the html tag. I leave you an article from the Docs that explains about the subject: https://developer.mozilla.org/en-US/docs/Web/CSS/length

  -One aspect that will help you a lot in your projects with Frontend Mentor is the use of the definition of color or font variables in the root.

  :root {
    --main-bg-color: brown;
    --color-for-text:  hsl(0, 0%, 100%);
   }
  
  .one {
     background-color: var(--main-bg-color);
  }
  
  .two{
    color: var(--color-for-text);
  
  }
  

  • Identifiers (including element names, classes, and IDs in selectors) are case-sensitive in css. Take that in mind when you define your clasess in the html.

  I guess that is for now. Happy coding!!.

  Marked as helpful

  0