Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

@GAOV13

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

devchsykas 220

@devchsykas

Posted

Hi, nice work, i like your project but i have a few suggestions

  1. Semantic HTML Elements: Consider using more semantic HTML elements to improve accessibility and SEO. For example, <main> could be used to wrap the main content area instead of <div class="card">.

  2. Class Naming: Ensure consistent and meaningful class names. For instance, card_item1 and card_item2 could be more descriptive, such as qr-code-container and content-container.

  3. Footer Attribution: Ensure the footer attribution is easily readable and accessible. Consider increasing the font size (font-size: 11px; may be too small for some users).

Marked as helpful

0

@eseoxalde

Posted

Great job. Maybe you should separate the CSS from the HTML by creating a new file

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord