QR code component

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted over 2 years ago

  👾Hello Saurav, congratulations for your solution!

  You've done pretty much anything, there are two things you do to clean your code and make the container have a better aspect in the mobile version.

  1.Use a single padding for all the component, you've use a padding property for the img h1 and p. A quick fix for that is removing all these paddings and add padding: 16px; to the container div.

  2.Add margin: 24px; to the container to avoid the container touching the screen bounds when you scale down the screen until 240px;.

  Hope it helps and congratulations again for the solution, seems really good. Happy coding!

  Marked as helpful

  1

  ---

  

  Saurav Jalui•40

  @SauravJaluiPosted over 2 years ago

  Hey @correlucas 👋

  Thank you for the feedback.

  I will implement these and update the solution soon.

  Happy coding to you too 👨‍💻

  1

  

  Lucas 👾•104,400

  @correlucasPosted over 2 years ago

  @SauravJalui you're Welcome Sarauv, keep it up!

  1
• 

  Suraj Raju Hadage•670

  @SurajHadagePosted over 2 years ago

  Most shortened, semantic & accessible HTML structure would be :

  <main>
    <figure>
      <img>
    </figure>
    <h1></h1>
    <p></p>
  </main>
  
  

  • I recommend you to not upload unnecessary files & folders to Github pages to save server space.
  • Use any app like Paint to get actual dimensions.

  0

  ---

  

  Saurav Jalui•40

  @SauravJaluiPosted over 2 years ago

  Thank you @SurajHadage. I will keep these in mind.

  0