QR code component

Community feedback

• 

  Shohanojjaman Emon•90

  @ShohanojjamanPosted over 1 year ago

  Hey @MohammedAlhaig98, Your design is looking good. But there are some issues on your design. Small improvements can be made though.

  • There is no semantics present in your solution
  • height is extremely restrictive and might cause overflow issues, therefore it is better to use min-height. Also for width. width will be max-width
  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain the purpose of the image. E.g. alt="QR code to frontendmentor.io" Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Thank you,

  Shohan

  Marked as helpful

  0

  ---

  

  Mohammed Abdurabu Alhaig•60

  @MohammedAlhaig98Posted over 1 year ago

  @Shohanojjaman Thanks for your advice but for point two i don't understand how to use min-height

  0

  

  Shohanojjaman Emon•90

  @ShohanojjamanPosted over 1 year ago

  @MohammedAlhaig98 There is an example-

  body {
  max-width: 100%;
  min-height: 100vh;
  }
  
  img{
  max-width:100%;
  }
  

  If you want to know more about this you can search on Google or other sites.

  Thank you,

  Shohan

  Marked as helpful

  0