QR code component challenge

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="container"> with the main tag and <h2> with <h1> to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/

  To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; min-height:100vh; display: grid place-items: center to the body. instead of giving .container a margin value. There is no need to give the body, html and .container height:100%;

  Use the color that were given in the styleguide.md

  Hope am helpful Happy coding

  Marked as helpful

  1

  ---

  

  Gulz•110

  @GulzhubPosted almost 2 years ago

  @Hassiai Thank you for your valuable feedback, Hassia. Your suggestions helped me in making the html more semantically correct. I have used the colors from the styleguide. You were super helpful. Keep up the good work. :)

  0