Design comparison
Community feedback
- @rayaattaPosted 10 months ago
Hello Divyansh Gemini๐, congratulations on completing your first FED challenge ๐
I have some suggestions you might find useful.
1 Try to make your html more Semantic by wrapping the main page content inside a
<main>
tag . Replace<div class="card">
With<main class="card">
. This changes nothing visually but Using it makes all the difference. Using semantic markup improvesSEO
And user experience (accessibility) for people using assistive technology such as screen readers.
2 The qr code should have text inside the alt attribute stating what it is and where it leads i.e
alt="qr code leading to frontendmentor.io
I hope this helps ๐
Otherwise your solution is neat๐
Happy coding โ๏ธ
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord