Skip to content
Submitted about 2 years ago

QR Code Component

Carlos•20
@vinci2fast
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 2 years ago

    Hi @vinci2fast 👋, good job completing this challenge! 🎉

    I have some suggestions you might consider to improve your code:

    • Use the <main> tag to wrap all the main content in your solution instead of using <div class="container">.
    • The alternative text must not contain hyphens, underscores, or the words "image" or "photo", it must be human readable.
    • To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.
    • Instead of using pixels in font size (font-size: 15px;), use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.

    Above all, the project is done well👏. I hope those tips will help you! 👍

    Good job, and happy coding! 😁

    Marked as helpful
    2
    Carlos•20
    @vinci2fastPosted about 2 years ago

    @MelvinAguilar this is really helpful! Thanks for this! I will make sure to keep this in mind as I do the other challenges!

    By the way, some questions:

    • For the <main> tag, should I just replace the <div class="container"> with it or should I nest it inside the <main>?
    • With the font size, do I need to initially specify the font size at the <body> tag or I can just omit that?
    1
    Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 2 years ago

    @vinci2fast Hi!

    • It is more advisable to use rem or em instead of pixels in everything, even in the font-size of the body, because the website adjusts completely to the user's font size. You can read more about this here
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord