QR Code Component

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Petros Devrikis•380

  @PetrosdevriPosted over 1 year ago

  @0xAbdulKhalid Appreciate the comment and will work on that, thank you!

  0
• 

  FlimzYT•110

  @FlimzYTPosted over 1 year ago

  Pretty good but you should fix the image dimensions and keep the ratio a 1:1 because it seems pretty stretched

  1

  ---

  

  Petros Devrikis•380

  @PetrosdevriPosted over 1 year ago

  @FlimzYT The main reason is that I left the initial file text so it would go up a bit, but you are right and I will work on the image size and border-radius.

  1