Skip to content
Submitted almost 2 years ago

Qr code component | Using Html , css

steevencode•120
@steeven509
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello everyone, It's been long time that i don't code I forget a lot of time now i need to pratice everyday for remenber a lot things any help would be helpful don't insist on correcting me Thank you !!!!!

Community feedback

  • Vanza Setia•27,775
    @vanzasetiaPosted almost 2 years ago

    Hi, @steeven509! 👋 Welcome back to coding! 😄

    I have some suggestions to improve this solution.

    • Remove <div class="qr-block-img">. Make the <img> as a block element and set the styling to the image directly instead of using <div>.
    • Improve the alternative text of the QR code by describing the purpose of the QR code. "QR code to frontendmentor.io" can be a good alternative text for it.
    • Use a CSS reset whenever you start a new project. This can help you set the styling foundation easily. My recommendation — A Modern CSS Reset
    • Remove height: auto; and overflow: hidden; from the .qr-container styling. It is because:
      • For the height, by default, the height of the element is set to auto and
      • For the overflow, there is no issue whether the property is there or not.
    • Never limit the height of the <body>. It will not allow the users to scroll the page when the page content needs more height. Try to look at the site on a mobile landscape view to see the issue. So, use min-height instead.
    • Never use px unit for font sizes. Use rem or em instead. Relative units such as rem and em can adapt when the users change the browser's font size setting.

    I hope you find this useful. 🙂

    Marked as helpful
    1
    steevencode•120
    @steeven509Posted almost 2 years ago

    @vanzasetia it’s very helpful my friend how can i keep in touch with you on other social networks

    0
    Vanza Setia•27,775
    @vanzasetiaPosted almost 2 years ago

    @steeven509

    I am available on the following social media platforms:

    P.S. I notice that we have connected on LinkedIn. 🙌

    Marked as helpful
    1
    steevencode•120
    @steeven509Posted almost 2 years ago

    @vanzasetia thank you

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord