Qr Code conponents

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  meissadev•10

  @meissadevPosted almost 2 years ago

  @denielden thanks for the feedback and advice. I will modify my work by applying your advice. My main difficulty was the dimensions and the units.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @meissadev You are welcome and keep it up :)

  0
• 

  Hassia Issah•50,670

  @HassiaiPosted almost 2 years ago

  Replace <div class="container"> with the main tag.

  Increase the width value of .container. replace the height value with a padding value. give img a width of 100% instead of a width and height value.

  Use rem or em as unit for the padding , margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To Aside from these you did well,

  Hope am helpful HAPPY CODING

  Marked as helpful

  1

  ---

  

  meissadev•10

  @meissadevPosted almost 2 years ago

  @Hassiai Thanks for your help I'll whatch the video.

  0