Skip to content
Submitted about 1 month ago

QR code component

Franck kapuya•40
@choupole
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

it'is so coll to make this challenge

Community feedback

  • Øystein Håberg•10,390
    @Islandstone89Posted about 1 month ago

    HTML:

    • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.

    • The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

    • Headings should always be in order, so you never start with a <h3>. I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

    • .attribution should be a <footer>, and you should use <p> for the text inside.

    CSS:

    • It is best practice to write CSS in a separate file, often called style.css. Create one in the same folder as the index.html, and link to it in the <head>: <link rel="stylesheet" href="style.css">.

    • Including a CSS Reset at the top is good practice.

    • I recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

    • Remove the margin on the card.

    • To center the card horizontally and vertically, with some space between the main and the footer, I would use Flexbox on the body:

    display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
min-height: 100svh;
gap: 2rem;

    • Remove all widths and heights. We rarely want to give a component a fixed size, as we want it to grow and shrink according to the screen size.

    • We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

    • Always set font-size in rem.

    • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

    • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

    • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

    • I would use px for the card padding - around 16px works fine.

    1
    Franck kapuya•40
    @choupolePosted about 1 month ago

    thanks for your device @Islandstone89

    1
  • Ali Koçak•80
    @KocakAliPosted about 1 month ago

    Good job!

    0
    Franck kapuya•40
    @choupolePosted about 1 month ago

    thanks for your support @KocakAli

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord