QR-code-component-main

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="container"> with the main tag, <div class="bold"><p> with <h1></h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/

  To center .container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body. instead of giving it a margin value

  Use rem or em as unit for the padding , margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To

  Hope am Helpful Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  remedan mohammedzeyn•30

  @remedanMPosted almost 2 years ago

  @Hassiai thank you for your helpfull comment

  0