QR code card using display flex css propertie

Hey there! 👋 Here are some suggestions to help improve your code:

• FEM Best practice ✅, before moving on to the next challenge, always check your FEM report, to see what is incorrect and update your code with it so that you would not make the same mistake over again. This should be the first thing that should be done right after submitting the challenge.

• The alt tag description for the “QR image” needs to be improved upon ⚠️. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

• Change ⚠️ the height to min-height in your body element, to improve your component's responsiveness.

• Change ⚠️ width to max-width in your component’s container to make it responsive.

• Add ⚠️ a max-width: 100% in your image to make it responsive.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! 🎆🎊🪅

Hello there 👋. Good job on completing the challenge !

I have some feedback for you if you want to improve your code.

HTML 📄:

• Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

• Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

Alt text 📷:

• The alt attribute should not contain underscores or hyphens, it must be human readable and understandable.

• The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

  If you want to learn more about the alt attribute, you can read this article. 📘.

CSS 🎨:

• Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport.

I hope you find it useful! 😄 Above all, the solution you submitted is great!

Happy coding!