Qr code component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="qr-card-container"> with the main tag and <h2> with <p> to fix the accessibility issues. click here for more on web-accessibility

  To center .qr-card-component on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units click here

  Give .Increase the padding value for .qr-card-component. Give the img a max-width of 100% instead of a width and height value, there is no need to give the img a padding value.

  Give h1 and p the same padding left and padding right values and the same margin-top values. Give p a margin bottom value. Give h1 a font-size of 15px.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Faais•30

  @mohammedfaaisPosted almost 2 years ago

  Thanks for your feedback Hassia.!

  0