QR code component

Community feedback

• 

  Dominik Gartz•140

  @domieeePosted almost 2 years ago

  🙋🏻‍♂️ Hi Davi,

  I took a look at your code, and a few little things caught my eye.

  • Instead of working with values in rem, use max-width: 300px; & width 100%; on your container. then img get's width: 100%. I think this would be a bit more elegant.

  • In this case the text Scan the QR code to visit Frontend Mentor and take your coding skills to the next level would rather fit into a <p> element, as the content is not what a heading should contain. Headings should describe something like a page-, oder section content.

  • After your <main> element you should rather nest with section > article instead of <div>. Div's are no longer the right way for a good, reachable page

  To learn more about web accessibility, check out this link

  • The height: 30.938rem; on the container should not be necessary. It would be enough to let the content and its paddings and margins control the height.

  That's what I noticed so, still good job finishing the project!

  EDIT: I don't think you need Media Queries for this Project :)

  Have a nice day and keep on coding! („ᵕᴗᵕ„)

  Marked as helpful

  1