Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

Davi de Oliveiraโ€ข 50

@QuintaFeiraNoite

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedbacks are always welcome :)

Community feedback

Dominik Gartzโ€ข 140

@domieee

Posted

๐Ÿ™‹๐Ÿปโ€โ™‚๏ธ Hi Davi,

I took a look at your code, and a few little things caught my eye.

  • Instead of working with values in rem, use max-width: 300px; & width 100%; on your container. then img get's width: 100%. I think this would be a bit more elegant.

  • In this case the text Scan the QR code to visit Frontend Mentor and take your coding skills to the next level would rather fit into a <p> element, as the content is not what a heading should contain. Headings should describe something like a page-, oder section content.

  • After your <main> element you should rather nest with section > article instead of <div>. Div's are no longer the right way for a good, reachable page

To learn more about web accessibility, check out this link

  • The height: 30.938rem; on the container should not be necessary. It would be enough to let the content and its paddings and margins control the height.

That's what I noticed so, still good job finishing the project!

EDIT: I don't think you need Media Queries for this Project :)

Have a nice day and keep on coding! (โ€žแต•แด—แต•โ€ž)

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord