Design comparison
SolutionDesign
Solution retrospective
My first challenge completed, all advice and criticism are welcome.
Community feedback
- @Bayoumi-devPosted over 2 years ago
Hey! Congratulations on completing this challenge... You have
accessibility issues
that need to fix.Document should have one main landmark
, Contain the component with<main>
.
<main> <div class="container"> //... </div> </main>
All page content should be contained by landmarks
, Contain the attribution with<footer>
.
<footer> <div class="attribution"> //... </div> </footer>
I hope this is helpful to you... Keep it up👍
Marked as helpful0@zbosecPosted over 2 years ago@Bayoumi-dev Thank you, this was my first project after long time of doing tutorial hell , so I kinda forgot half the things.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord