Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Do not forgot to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
- The
alt tag
description for the “QR image” needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.
- Avoid using
inline CSS
as it can clutter your code and make it diff to maintain.
- Change
width
tomax-width
in your component’s container to make it responsive. You will also want to remove theheight
as it is unnecessary.
- Change
width
tomax-width: 100%
in your image to make it responsive. You will also want to remove theheight
as it is unnecessary.
- For improved accessibility 📈 for your content, it is best practice to use
rem
for yourfont-size
and other property value. Using this unit gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord