Semantic HTML5 markup and mobile-first workflow

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  You have written the link to the Github repository incorrectly.

  HTML 📄:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • Use the <footer> tag to wrap the footer of the page instead of the <div class="footer">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

  • The text Improve Your Front-End Skills by Building Projects is considered a heading element (h1).

  Alt text 📷:

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  0

  ---

  

  Hasan Osman•40

  @hasanosman2020Posted almost 2 years ago

  @MelvinAguilar

  Hello Melvin - many thanks for your helpful comments, particularly those with regards to accessibility. I do enjoy the topic of accessibility and, in light of your comments, I shall amend my solution to be more robust in that respect.

  Very helpful indeed. Many thanks

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="container"> with a main tag and wrap the heading in <h1> to fix the accessibility issue. click here for more on web-accessibility and semantic html

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Hasan Osman•40

  @hasanosman2020Posted almost 2 years ago

  @Hassiai

  Hello Hassial - your comments are very helpful. Thank you for the links to the articles you mention - the information they contain is very useful. Thank you also for taking the time to review and respond to my solution. I shall edit and repost my solution taking your comments into consideration.

  Many thanks for your time and effort. Thank you.

  1