Design comparison
Community feedback
- @JunoFieldPosted almost 2 years ago
Hi,
This was a great attempt, just a few suggestions:
Some of the CSS "tweaks" you've added aren't necessary for this project - sections 7 and 8 for example. There's no real need to remove these - just thought I'd make you aware.
Ideally the main element should be centered - another commented mentioned a
grid
solution, but personally I'd just use absolute positioning. This can be done by adding this to the centre card's CSS:position: absolute; left: 50%; top: 50%; transform: translateXY(-50%, -50%);
Also, take note of the issues raised in the FM report:
- Alt text: Personally I'd either make it empty or add a link, but neither are ideal solutions in production so it's really up to you.
- Main tag required: This one's simple: just change your
section
tag tomain
and update the CSS to suit. - Attribution section: Personally I'd replace
div
withfooter
for the attribution to fit this requirement.
Speaking of the attribution section, don't forget to fill it out with your name and profile. I also like to move its styling from the HTML file to the CSS file but that's down to preference.
Good luck!
0 - @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Do not forget ⚠️ to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
- To properly center ✅ your content to your page, you will want to add the following to your
body
(this method uses CSS Grid):
body { min-height: 100vh; display: grid; place-content: center; }
More Info: 📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord