@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- Figure elements (
<figure>) should only be used when captions are required with<figcaption>, you can directly use the div tag in this solution.
Alt text 📷:
- The
altattribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.
-
The
altattribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteraltattribute would beQR code to frontendmentor.ioIf you want to learn more about the
altattribute, you can read this article. 📘.
CSS 🎨:
- To fix the text, you should remove the
flex-wrap: wrap;on the.containerselector.
- Setting the font-size to 62.5% can attract compatibility issues with third-party libraries or plugins. You can read more about this with this two lectures:
Credit to grace-snow and vanzasetia for pointing this out.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@Sachin-Mahato
Posted
@MelvinAguilar I don't know how to give a good class name, can you help how to come up with a good class name?
@MelvinAguilar
Posted
@Sachin0000000 Hi! I suggest you to learn the BEM naming convention. The BEM (Block, Element, Modifier) naming convention is a methodology for naming HTML classes used in web development. It is a way of breaking down the structure of a website into smaller, reusable parts. The BEM naming convention uses three levels of specificity: Block, Element and Modifier. Blocks are the highest level of specificity and represent the root of a component. The syntax for BEM class names follows this pattern: block__element--modifier.
e.g:
<div class="card">
<img src="image.jpg" class="card__image"/>
<div class="card__text">...</div>
</div>
Marked as helpful
