Submitted 5 months ago

QR code component

Keoua• 70

@scuzzi808

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Not needing to look at any solutions

What challenges did you encounter, and how did you overcome them?

media queries and some issues with height and with in terms of responsiveness and getting everything to shrink correctly.

What specific areas of your project would you like help with?

My main issue is still dealing with media queries with responsiveness and getting all the content to shrink consistently when changing to mobile. I also want to start using other values for width and height for better responsiveness... Any other tips would be greatly appreciated!!

Community feedback

Vanessa M.• 350

@mendezpvi

Posted 5 months ago

Excellent work! 👏, I have some suggestions:

Use semantic tags. For example, the class qr-wrapper can be an article or section.
I consider the tags of the container and qrtext classes to be unnecessary.
The text-align and padding properties can go in the qr-wrapper class.
The requirements of this project indicate that the media query is not necessary, the card does not change.
The properties you gave to the wrapper class would be better given to the body, changing the height to min-height: 100vh. Then you apply a padding-block or margin-block to footer of your discretion. Ex. 1rem.
You forgot to change the font, and the background doesn't match. Every detail counts.

I invite you to visit my solution here

Happy coding! 😎

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord