Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
Not needing to look at any solutions
What challenges did you encounter, and how did you overcome them?media queries and some issues with height and with in terms of responsiveness and getting everything to shrink correctly.
What specific areas of your project would you like help with?My main issue is still dealing with media queries with responsiveness and getting all the content to shrink consistently when changing to mobile. I also want to start using other values for width and height for better responsiveness... Any other tips would be greatly appreciated!!
Community feedback
- Account deleted
Excellent work! 👏, I have some suggestions:
- Use semantic tags. For example, the class
qr-wrapper
can be anarticle
orsection
. - I consider the tags of the
container
andqrtext
classes to be unnecessary. - The
text-align
andpadding
properties can go in theqr-wrapper
class. - The requirements of this project indicate that the media query is not necessary, the card does not change.
- The properties you gave to the
wrapper
class would be better given to thebody
, changing theheight
tomin-height: 100vh
. Then you apply apadding-block
ormargin-block
tofooter
of your discretion. Ex. 1rem. - You forgot to change the
font
, and thebackground
doesn't match. Every detail counts.
I invite you to visit my solution here
Happy coding! 😎
0 - Use semantic tags. For example, the class
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord