QR code component

Community feedback

• 

  MonicaPoloni•60

  @MonicaPoloniPosted 9 months ago

  very good! It is very similar to the pre-proposed challenge. Excellent! :)

  Marked as helpful

  1

  ---

  

  GLBonfim•60

  @GLBonfimPosted 9 months ago

  Thanks @MonicaPoloni!!

  0
• 

  Bishal Singh Deo🎮•1,440

  @Bishalsnghd07Posted 9 months ago

  Hi, @GLBonfim

  Nice work👏 and congrats for completing this challenge🎉

  I have a only suggestion for you, I see your code you used height in your body, I will recommend to use min-height instead of height in a body or in a main landmark, never ever use height in body it will only break your layout. It is not effecting in small projects, but when you work on larger projects it will give you a disaster solution.

  body { height: 100vh;❌ min-height: 100vh;✅ }

  Hope, this suggestion will help you!

  Once again Welcome to Frontend Mentor, wishing you a joyful journey and happy coding❤️

  Marked as helpful

  1