Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr code component

@ErfanTardast

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


still have problem on mobile size if you have any solution , im glad to read that

Community feedback

Daniel 🛸 44,230

@danielmrz-dev

Posted

Hello @ErfanTardast!

Your solution looks great!

I have a couple of suggestions for improvement:

  • In order to make your HTML code more semantic, and since that is the main title of the screen, replace the <p> with <h1>. Unlike what most people think, it's not just about the size and weight of the text.

The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on.

  • Also, still about semantic HTML, replace your div.container with main.container.

All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

0

@ErfanTardast

Posted

Thanks a lot I will do the changes ♥️🙏@danielmrz-dev

1

@djamkenny

Posted

The are several ways to tackle mobile size, either you choose the mobile first way or you use @medial screen {} where you set the screen size and write the code to repond to the size.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord