Submitted 5 months ago

QR code Component

Shivian• 40

@Andre-DM

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I think it is a good practice to use custom properties, even if they are not required in a small project like this. It is a feature that I will use in any future project from now on.

What challenges did you encounter, and how did you overcome them?

I did not find any particular difficulties in doing this challenge.

What specific areas of your project would you like help with?

I would like to improve on using the various divs to group different types of text, in this case the h1 and paragraph, and manage the various margins and paddings. Are there better methods for arranging the text than the one in my solution?

Community feedback

Bernardo Poggioni• 5,140

@R3ygoski

Posted 5 months ago

Ciao Shivian, congrats for conclude this challenge, it's very good and almost similar to proposed design.

I want to start saying about custom proprerties, yes you are right, it's a good pratice to always use it, so, keep it.

A hint about HTML, I highly recommend to use Semantic HTML, because it's increase accessibiliy of your project, some examples: your <div class="qr-code"> could be and <figure> tag, your <div class="description"> could be an <article> tag. Here's a link about it: W3School - Semantic HMTL.

Again, congratulations, your project is really good, keep practicing, if something that I said is unclear, please, comment below and I will try to help.

Marked as helpful

Shivian• 40

@Andre-DM

Posted 5 months ago

@R3ygoski Hi there! Thank you so much for taking the time to leave me some feedback, I will make the changes you suggested right away and keep these tips in mind for future projects!

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord