QR code component

Community feedback

• 

  romila•3,570

  @romila2003Posted about 2 years ago

  Hi Nikhil,

  Congratulations 🎉 for completing this challenge, the card looks great. It is great that you used the flex property to center the card. I have some suggestions I want to address:

  1. Even though, you used the correct semantic for the main body, you should also wrap the footer within the footer tag which should be nested within the body and outside of the main tag e.g. <footer class="attribution"></footer>
  2. The texts are missing the font-family and color property. The p tag's color is quite quite light and in the original design, it is gray.
  3. I would recommend you giving the background-color property to the body instead of the main tag, as the body will cover everything however the container will only cover the container.

  Overall, great attempt and wish you the best for your future projects so keep coding 👍.

  Marked as helpful

  0

  ---

  

  Nikhil Sharma•340

  @NIk22517Posted about 2 years ago

  @romila2003 Thank you for the positive feedback! It means a lot to know you've noticed

  1