Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

@shivani0401

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please suggest to me the best practices!

Community feedback

@RajputChirag27

Posted

The above solution you submitted was great. Few changes must be implemented to make your solution better.

  1. Use rem instead of px.
  2. Use h tags i.e, h1,h2...,h6 instead of leaving them as it is. h tags marks the priority of the text.
  3. Last point is just a suggestion that you can use flex to make your solution more responsive and using flex will make your life easier. For E:g, To center a div you just have to set
.container{
display: flex;
justify-content: center;  // To center the main axis x-axis if row and y-axis if column
align-items: center;  // To center the secondary axis
}

Hope you will like the feedback, if you find it helpful then upvote me. Good Day!!

0
Ian Ramos 120

@i-ramoss

Posted

Hi @shivani0401 how are you?

Some suggestions for you to improve your project and facilitate its development:

  • Avoids styling the HTML within the HTML file itself, it's more interesting and more readable to create a separate style.css file for styling.
  • It's always interesting to use semantic tags right after the body, like section, main, aside, header, footer...
  • Take a look at this article to better understand how and where to use each CSS unit. It's in PT-BR. https://dev.to/lixeletto/entendendo-unidades-css-e-Quem-utiliza-las-3ecc
  • Use the git init command within the project page, to avoid uploading the folder to the GitHub repository.
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord