QR code component

Community feedback

• 

  RAJPUT CHIRAGSINGH ARJUNSINGH•50

  @RajputChirag27Posted over 1 year ago

  The above solution you submitted was great. Few changes must be implemented to make your solution better.

  1. Use rem instead of px.
  2. Use h tags i.e, h1,h2...,h6 instead of leaving them as it is. h tags marks the priority of the text.
  3. Last point is just a suggestion that you can use flex to make your solution more responsive and using flex will make your life easier. For E:g, To center a div you just have to set

  .container{
  display: flex;
  justify-content: center;  // To center the main axis x-axis if row and y-axis if column
  align-items: center;  // To center the secondary axis
  }
  

  Hope you will like the feedback, if you find it helpful then upvote me. Good Day!!

  0
• 

  Ian Ramos•120

  @i-ramossPosted over 1 year ago

  Hi @shivani0401 how are you?

  Some suggestions for you to improve your project and facilitate its development:

  • Avoids styling the HTML within the HTML file itself, it's more interesting and more readable to create a separate style.css file for styling.
  • It's always interesting to use semantic tags right after the body, like section, main, aside, header, footer...
  • Take a look at this article to better understand how and where to use each CSS unit. It's in PT-BR. https://dev.to/lixeletto/entendendo-unidades-css-e-Quem-utiliza-las-3ecc
  • Use the git init command within the project page, to avoid uploading the folder to the GitHub repository.

  0