QR Code Component

Community feedback

• 

  TreNyceCodes•230

  @TrenyceCodesPosted over 1 year ago

  Good Job on Finishing your First challenge

  For your HTML img element src attribute you forgot to add a dot before the slash Change from: <img src="/images/image-qr-code.png"> To <img src="./images/image-qr-code.png">

  Also put your attributes stuff below your qr-component code. That should fix it

  Hope that helps

  2
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="wrapper"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1
• 

  Leonardo Romero•150

  @LeonardoR3DPosted over 1 year ago

  Question: How did you approach centering the QR code design on the webpage? I implemented it somehow but I'm not sure if I used the right approach.

  Answer: I think the way you have done it is fine, the only problem I see is that if you want to resize the "outer-container" you have to resize the QR code manually, so I suggest you change the width of the QR code to 100% to fit its container and add a horizontal padding to the "outer-containerr" to center everything, this way every time you resize the "outer-container" the image will resize too.

  Extra tip: If you have done the above, you can remove the "text-box" and add a new style rule to the <p> elements to add a horizontal padding, this way the text will change with the size of the "outer-container" as well.

  1