QR code component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace<div class="container">with the main tag and <div class="attribution"> with the footer tag and wrap Improve your front-end skills by building projects within <h1> to make the page/content accessible. click here for more on web-accessibility and semantic html

  The image is not visible because neither the qr-code image nor the images folder is in the repository either you add the image directly to the repository and change the src value of the img to image-qr-code.png or add the images folder to the repository and add "./" to the beginning of the src value, <img src="./images/image-qr-code.png">.

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  Give h1 and p text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  There is no need to style .container and to give the body overflow value in the css.

  For a responsive content,

  • Replace the width in .qr-box with max-width, reduce its value and replace the height padding value for all the sides max-width: 320px which is 20rem/em padding:16px which is 1rem/em
  • Give the img a max-width of 100% and a border-radius value, the rest are not needed.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0
• 

  Sahil Singh Tomar•70

  @SahilSinghTomarPosted over 1 year ago

  Hey, Upload images to github as well to view images. btw nicely done

  0