Atom- QR-Code challenge

Community feedback

• 

  Zeyad Mohamed•320

  @ZeyadMohamed1805Posted almost 2 years ago

  Hello there! 🤗 Your project looks awesome! 🎇

  • Regarding the font size and colors, make sure you check out the style-guide file within the project's downloaded zip-file! It should contain all the information you need to know about the colors & fonts. It must be one of them 🎨
  • Also for your text element, you set its (margin: 80px auto 80px auto;) If you replace that with just (margin: 80px auto), it will generate the same result! 🎊

  Keep up the great work!🔝 I hope you find this to be helpful 😁

  Marked as helpful

  0
• 

  Hassia Issah•50,670

  @HassiaiPosted almost 2 years ago

  Replace <div class="text"> with the main tag and <p class="p1"> with <h1> to fix accessibility. click here for more on web-accessibility

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units. click here

  To center .text on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  For a responsive content there is no need to give .text a heigh value replace it a padding values for all the sides.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0