Skip to content
Submitted over 2 years ago

QR Code Component

Akadzani•10
@Akadzani
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I would like to get the feedback for how i write the code for this challenge.

Community feedback

  • Naveen Gumaste•10,480
    @NaveenGumastePosted over 2 years ago

    Hello Akadzani ! Congo 👏 on completing this challenge

    Let's look at some of your issues, shall we:

    • Warp your card content around the main tag Ex: 👇
    <body>
<main class="container">
*all you content here*
</main>
</body>

    happy Coding😀

    Marked as helpful
    0
    Akadzani•10
    @AkadzaniPosted over 2 years ago

    @Crazimonk Hello Naveen, thank you for the helpful feedback.

    1
  • LiBee•370
    @Li-BeePosted over 2 years ago

    Pretty close to the design - well done 👏. Compared to the design i think you need to make the heading smaller and add a bit of space between the bottom of the paragraph and the bottom of the card.

    To fix your accessibility issues you need to add <main></main> to your html - to add a landmark.

    <body>
<main>
    <div class="qr-code container">
     ....
    </div>
    <div class="attribution">
    </div>
</main>
</body>
    Marked as helpful
    0
    Akadzani•10
    @AkadzaniPosted over 2 years ago

    @Li-Bee Hello Li-Bee, thank you for the feedback, it's really helpful.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord