Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

cryptosossoβ€’ 150

@cryptososso

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

cryptosossoβ€’ 150

@cryptososso

Posted

Hi, @MelvinAguilar Thank you very much for your feedback and the resources. I'll use them for my other challenges.

1

@MelvinAguilar

Posted

Hi @cryptososso πŸ‘‹, good job on completing this challenge! πŸŽ‰

I have some suggestions you might consider to improve your code:

  • Use the <main> tag to wrap all the main content in your solution instead of using <div class="container">, also, there should only be one man tag.
  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
  • The container isn't centered correctly. There are two modern CSS techniques to center elements:

Using flexbox layout:

body {
   min-height: 100vh;
   display: flex;
   flex-direction: column;
   justify-content: center;
   align-items: center;
}

Using grid layout:

body {
   min-height: 100vh;
   display: grid;
   place-content: center;
}

Additionally, remove the margin to center the component correctly.

.container {
    /* margin: 0 auto; */
    /* margin-top: 100px; */
    /* margin-bottom: 15px; */
    . . . 
}

Links with more information:

I hope those tips will help you! πŸ‘

Good job, and happy coding! 😁

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord