Melvin Aguilar π§π»βπ»β’ 61,220
@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML π·οΈ:
- Wrap the page's whole main content in the
<main>
tag.
CSS π¨:
-
Do not use
overflow: hidden
on the body element, this will prevent scrolling on some devices. -
The simplest way to set the height of the .wrapper element is with
min-height: 100vh
, setting the height to 100% on both the body and html elements can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.
.wrapper {
/* min-height: 100%; */
/* overflow: hidden; */
min-height: 100vh;
background-color: hsl(212, 45%, 89%);
/* height: 100%; */
/* width: 100%; */
display: flex;
}
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource π.
I hope you find it useful! π
Happy coding!
0