QR Code Component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Wrap the page's whole main content in the <main> tag.

  CSS 🎨:

  • Do not use overflow: hidden on the body element, this will prevent scrolling on some devices.

  • The simplest way to set the height of the .wrapper element is with min-height: 100vh, setting the height to 100% on both the body and html elements can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.

  .wrapper {
      /* min-height: 100%; */
      /* overflow: hidden; */
      min-height: 100vh;
      background-color: hsl(212, 45%, 89%);
      /* height: 100%; */
      /* width: 100%; */
      display: flex;
  }
  

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘.

  I hope you find it useful! 😄

  Happy coding!

  0