QR code component

Community feedback

• 

  Adriano•39,370

  @AdrianoEscarabotePosted about 1 month ago

  Hi a-n-i-s, how’s everything? I think your project turned out great! However, I have some feedback that I think might be useful:

  images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader.

  Learn the differences between decorative/meaningless images vs important content.

  The rest is amazing.

  I hope this is helpful. 👍

  Marked as helpful

  1
• 

  bonzoycv•10

  @bonzoycvPosted about 1 month ago

  • CSS variables are used for colors, which is a good practice for maintainability.
  • The <h2> tag is used for the card title, but there's no <h1> on the page.Did you consider using <h1> for the main heading?
  • The .container div could be removed, and the flexbox properties applied directly to the <main> element.

  Great job, the code is very clear and easy to read, your code help me a lot to understand more how to approach this kind of problems specially with flexbox, Now I will go to fix mine. KUDOS!

  1