Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

a-n-i-s 30

@a-n-i-s

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Adriano 37,150

@AdrianoEscarabote

Posted

Hi a-n-i-s, how’s everything? I think your project turned out great! However, I have some feedback that I think might be useful:

images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader.

Learn the differences between decorative/meaningless images vs important content.

The rest is amazing.

I hope this is helpful. 👍

Marked as helpful

1
P
bonzoycv 10

@bonzoycv

Posted

  • CSS variables are used for colors, which is a good practice for maintainability.
  • The <h2> tag is used for the card title, but there's no <h1> on the page.Did you consider using <h1> for the main heading?
  • The .container div could be removed, and the flexbox properties applied directly to the <main> element.

Great job, the code is very clear and easy to read, your code help me a lot to understand more how to approach this kind of problems specially with flexbox, Now I will go to fix mine. KUDOS!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord