Submitted over 1 year ago

Responsive Barcode

Harvinder Singh• 80

@7046gunnu

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Community feedback

Melvin Aguilar 🧑🏻‍💻• 61,220

@MelvinAguilar

Posted over 1 year ago

Hello there 👋. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

HTML 📄:

The lang attribute is used to declare the language of the webpage. Add the lang attribute to the <html> tag with the value en.

The viewport meta tag is missing. the viewport meta tag is used to control the layout of the page on mobile devices. Add the viewport meta tag to the <head> tag: <meta name="viewport" content="width=device-width, initial-scale=1.0">

The <title> tag is used to specify the title of a web page, which is displayed in the browser's title bar or tab, and is also used by search engines as the title of a page in search results.

Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

You must use a level-one heading (h1) even though this is not a full-page challenge.

Alt text 📷:

The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

If you want to learn more about the alt attribute, you can read this article. 📘.

CSS 🎨:

Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here 📘.

I hope you find it useful! 😄

Happy coding!

Marked as helpful

Hassia Issah• 50,670

@Hassiai

Posted over 1 year ago

Add a language attribute lang="en" to the html tag <html>, add a tittle tag <tittle></tittle> within the head tag, add the alt attribute alt=" " to the img tag to fix the error isues. The value for the alt attribute is the description of the image.

Give the tittle tag a content, its content is the tittle of the html file. Replace <div class="back"> with the main tag, <h2> with <h1> and h4 with <p> to fix the accessibility issue. click here for more on web-accessibility and semantic html

The body has a wrong background-color. Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

To center .back on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

To center .back on the page using flexbox:
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}

To center .back on the page using grid:
body{
min-height: 100vh;
display: grid;
place-items: center;
}

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord