Skip to content
Submitted 8 months ago

QR code component

Micha087•40
@Micha087
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am proud that i managed to do the challenge and try to make it look the same. Not sure how i would approach it differently next time but it's just the beginning

What challenges did you encounter, and how did you overcome them?

getting the content in the center but i got it at the end, just did some research

What specific areas of your project would you like help with?

probably write cleaner code

Community feedback

  • Harsh Kumar Dwivedi•740
    @Harsh-Kumar-DwivediPosted 8 months ago

    Hi @Micha087 ,

    I think you can make markup more semantic by using <main> element instead of <div class="card"> and <footer> element instead of <div class="attribution">. This will improve accessibility.

    Hope it is helpful !

    Happy Coding !

    0
    Micha087•40
    @Micha087Posted 8 months ago

    Hi @Harsh-Kumar-Dwivedi do you mean replace the divs with main and footer element or surround the <div class="card"> with the main element and <div class="attribution"> with the footer element?

    0
    Harsh Kumar Dwivedi•740
    @Harsh-Kumar-DwivediPosted 8 months ago

    @Micha087

    Both will work, but it would be better to replace as it will not become extra code then and also you can style them using element selectors only instead of assigning classes.

    Hope this helps !

    1
    Micha087•40
    @Micha087Posted 8 months ago

    @Harsh-Kumar-Dwivedi Thanks for the advice, i will keep it in mind for future challenges

    0
    Harsh Kumar Dwivedi•740
    @Harsh-Kumar-DwivediPosted 8 months ago

    @Micha087

    Welcome !

    If you find it helpful, please consider marking it as "Marked as helpful".

    Happy Coding !

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord