/* .attribution { font-size: 11px; text-align: center; } .attribution
Design comparison
Solution retrospective
all feedback is welcomed thank you
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="ext-box"> with the main tag and <div class="paragraph-1"><p> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html
To center .ext-box on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
There is no need to give .ext-box display: block; Give the img a max-width of 100% instead of a width value.
Replace the height value in .ext-box with a padding value for all the sides. Give h1 and padding the padding left and padding- right values and the same margin-top values.
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@akhribabderahmanePosted almost 2 years ago@Hassiai thank you so much , I really appreciate it .... I'll fix it .
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord