QR Code Component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @Vinzz34 👋, good job completing this new challenge! 🎉

  I have some suggestions you might consider to improve your code:

  • The alternative text must not contain hyphens, underscores, or the words "image" or "photo", it must be human readable.

  • To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.

  • Use width: 100%; instead of max-width: 29rem in the image selector to make responsive images.

  • Use margin: 0.938rem in the .container selector to add some space for the container card and the screen edge on mobile devices.

  Above all, the project is done well👏.

  Good job, and happy coding! 😁

  Marked as helpful

  3