Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

@Syedjawad7

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Make sure easy QR code component using html and css. Love to know suggestions and collaborate !!

Community feedback

@Mitko90

Posted

Hey there, congrats onthe solution 🎉️

It looks good

Maybe I can suggest something

  • You don't need the poitioning here
.cont{
    display: grid;
    place-items: center;
    position: relative;
    top: 50px;
}

Do this instead

body{
	display: grid;
	place-items: center;
	min-height: 100vh;
}

and you card should be centered. So now you can remove completely the <div class="cont"> as you son't need it.

  • On your .child remove the height as it causes issues.

  • There is no need to give font-size on img as it is an image, it doesn't need a font size.

  • You can remove the font-family from the p as it is set in the .child class.

  • You can also remove all the position: relative top and right because all the text is aligned center so it shoud be ok.

Hope you find this helpful.

Keep up the good work and Happy coding 👍️

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord