@Hassiai
Posted
Replace<div class="card">with the main tag, <p class="improve"> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
change the value of the font-size to 15px.
To center .card on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
To center .card on the page using flexbox:
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
To center .card on the page using grid:
body{
min-height: 100vh;
display: grid;
place-items: center;
}
There is no need to give .card a height value and display: inline-block. Give .card equal padding value for all the sides. padding: 20px. Increase the width of .card for it to be equivalent to the width of the design. width:300px.
Give the img a max-width of 100% instead of a height value. Give p and h1 the same margin-left, margin-right and margin-top values. Give p a margin bottom value.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
