QR code component

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi @wasimfakruddin, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
  • Replace the <h> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
  • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
  • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  wasim fakruddin•50

  @wasimfakruddinPosted about 2 years ago

  @correlucas thankyou for the guidance

  0
• 

  Kairat Kempirbaev•260

  @kairat-kempirbaevPosted about 2 years ago

  Hi Wasim,

  I have a feeling the text needs the same amount of pixels as a gap. (For re-usability em,rem,vw metrics are easier to maintain)

  Container needs alignment. Padding should match the QR code image gap. In my opinion making a small gap between the border of a container would be a great solution. No need to have exact padding.

  This tutorial helped me the most: https://scrimba.com/learn/design

  I don't know whether frontendmentor partnered with scrimba but both learning platforms teach the Space Travel Mission. I think it won't hurt to review both.

  Nice work

  Happy coding.

  Marked as helpful

  0

  ---

  

  wasim fakruddin•50

  @wasimfakruddinPosted about 2 years ago

  @kairat-kempirbaev thankyou soo much for the review surely will improve my coding ability even further

  1

  

  wasim fakruddin•50

  @wasimfakruddinPosted about 2 years ago

  @kairat-kempirbaev thankyou for the guidance

  0