QR code component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace<div class="container">with the main tag, <h2> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  The body has a wrong background-color. To center .qr-container on the page using flexbox, replace the height with min-height:100vh.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1
• 

  Dominik Gartz•140

  @domieeePosted almost 2 years ago

  🙋🏻‍♂️Hi manta-lucian,

  I noticed only a few small things:

  • Instead of using div element, you should rather use a nesting with main > section. This is important for web accessibility. Take a look here

  • Instead of the fixed width of 300px, use max-width: 300px; + width: 100%. The img will keep the width: 100%;. This way everything remains responsive.

  P.S. Change the background-color property of your body 😜

  Edit: Also take a look at the h2 and change it to h1. h1 has to be the first heading in your code. Here's how you handle headings

  Haven't found anything else yet, maybe someone else will find something

  Otherwise great project and keep coding!◝(ᵔᵕᵔ)◜

  Marked as helpful

  1