Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

Sienteloโ€ข 190

@manta-lucian

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hassia Issahโ€ข 50,670

@Hassiai

Posted

Replace<div class="container">with the main tag, <h2> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

The body has a wrong background-color. To center .qr-container on the page using flexbox, replace the height with min-height:100vh.

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

1
Dominik Gartzโ€ข 140

@domieee

Posted

๐Ÿ™‹๐Ÿปโ€โ™‚๏ธHi manta-lucian,

I noticed only a few small things:

  • Instead of using div element, you should rather use a nesting with main > section. This is important for web accessibility. Take a look here

  • Instead of the fixed width of 300px, use max-width: 300px; + width: 100%. The img will keep the width: 100%;. This way everything remains responsive.

P.S. Change the background-color property of your body ๐Ÿ˜œ

Edit: Also take a look at the h2 and change it to h1. h1 has to be the first heading in your code. Here's how you handle headings

Haven't found anything else yet, maybe someone else will find something

Otherwise great project and keep coding!โ—(แต”แต•แต”)โ—œ

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord