QR Code Component

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi Zizi Aymen, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

  Fix the alignment:

  }
  body {
      min-height: 100vh;
      background-color: hsl(212, 45%, 89%);
      font-family: 'Outfit', sans-serif;
      font-size: 15px;
      display: flex;
      align-items: center;
      justify-content: center;
      flex-direction: column;
  }
  

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  2
• 

  Darren O'Hehir•50

  @darrenohelloPosted about 2 years ago

  Nice work @zizi-ayman, I just finished this challenge recently too.

  I'm a beginner so keep that in mind - but it seems like if a percentage value on the border-radius is used, the curve won't be perfectly circular. So if you use a fixed value (like px) the curve should be perfectly rounded.

  So updating this from 4% to something like 16px will make it pixel-perfect.

  div {
      border-radius: 4%;
  

  div {
      border-radius: 16px;
  

  I hope that helps and well done.

  Marked as helpful

  1