QR-CODE-COMPONENT

Hello there 👋. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

Alt text 📷:

• The alt attribute should not contain underscores or hyphens, it must be human readable and understandable.

• The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

  If you want to learn more about the alt attribute, you can read this article. 📘.

CSS 🎨:

• Setting the width of the component with a percentage or a viewport unit will behave strangely on mobile devices or large screens. You should use a max-width of 320px or 20rem to make sure that the component will have a maximum width of 320px on any device, also remove the width property with a percentage value.

This is a picture of what mobile devices look like: screencapture-duckit69-github-io-qr-code-component

Update to this:

.holder {
    /* max-width: 18%; */
    max-width: 320px;
    margin: 1rem; /* Add a small margin*/
   . . .
}

• Use box-sizing in the * selector, not just in the body, so that all elements have that property.

Do:

* {
    box-sizing: border-box;
}

Instead of:

body {
    box-sizing: border-box;
}

I hope you find it useful! 😄 Above all, the solution you submitted is great!

Happy coding!

Replace the <h3> with <h1> to fix the accessibility issues.

To center .holder on the page using flexbox, replace the height in the main with min-heerght:100vh.

There is no need to give .holder a max-height value or a height value rather give it a padding value for all the sides.

Give the img a max-width of 100% and a border-radius value the rest of the styling are not needed. Give h1 a font-size of 15px..

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING