@denielden
Posted
Hi Dumbxguy, I took some time to look at your solution and you did a great job!
Upload the files directly to the repository and not into the qr-code
folder otherwise to see it the link is this: https://dumbxguy.github.io/frontend-mentor-challenge/qrcode/
You get good frontend developer at try and writing a lot of code :)
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - use
img
element for the qr image, not adiv
and add descriptive text in theiralt
attribute - remove all
margin
frommaincard
class - try to use flexbox to the body for center the card. Read here -> best flex guide
- after add
min-heigth: 100vh
to body because Flexbox aligns to the size of the parent container
Overall you did well :)
Hope this help and happy coding!
Marked as helpful