qr code component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Dumbxguy, I took some time to look at your solution and you did a great job!

  Upload the files directly to the repository and not into the qr-code folder otherwise to see it the link is this: https://dumbxguy.github.io/frontend-mentor-challenge/qrcode/

  You get good frontend developer at try and writing a lot of code :)

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • use img element for the qr image, not a div and add descriptive text in their alt attribute
  • remove all margin from maincard class
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after add min-heigth: 100vh to body because Flexbox aligns to the size of the parent container

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  1
• 

  dumbxguy•10

  @DumbxGuyPosted almost 3 years ago

  Thank you so much sir for giving such precious time to give feedback🙏 It means a lot for me .... Sir i tried using image tag instead of div but that tag wasn't working.. so i use div tag Thank you for the tips and I will apply all your tips and do it again.🙏❤️

                               Thank you sir🙏❤️
  

  1

  ---

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @DumbxGuy Why it does not work?

  Try entering this code: <img alt="qr code" src="images/qrcode.png">

  0