QR Code Component (HTML/CSS)

Community feedback

• 

  Hugo F Hernandez•50

  @HugoHernPosted almost 2 years ago

  • Your solution is really close to the original
  • Your CSS looks great, its really clean and organized
  • The only criticism I have is the spacing between elements
  • It looks like you only need to tweak the font sizes in your html

  Marked as helpful

  1
• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The alt tag description for the “QR image” needs to be improved upon ⚠️. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

  • The "Improve your front-end skill by building projects" is a heading ⚠️ in this component, so should be wrapped in an heading element.

  • The height: 500px; in the component’s container is not needed ⚠️.

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-size and other property values. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  1