Qr code solution

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  replace <div class="wrapper"> with the main tag , <div class="attribution"> with the footer tag to fix the accessibility issues. To center a content on a page, add min-height:100vh; to the body and remove the height value change the width value of .wrapper , give the width value of .wrapper 400px , a padding value, a background-color of white and a border-radius value: e.g. wrapper{ width: 400px; padding:16px; background-color: hsl(0,0,100%); border-radius:15px}

  Give img a width of 100% or max-width of 100%. there is no need to give the img a width and height value. Give .text area a padding value in for all the sides: .textarea{padding:16px;} instead of giving h1 and p a margin value. Give .textarea p a margin-top value for the space between the text and remove the font weight value. You forgot to add the media query, in the media . wrapper a width of 80%.{ e.g: @media (max-width:400px){ .wrapper{width:80%}}

  Use the colors that were given in the styleguide.md found in the starter folder.

  Use rem or em as unit for the padding , margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To

  Hope am helpful HAPPY CODING

  1

  ---

  

  Ameer Mavia•160

  @Murat-cmdPosted almost 2 years ago

  @Hassiai Thank you so much for this, I really have learned a lot from this. Will surely be better in future projects. Thanks again

  0