QR code component

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted over 2 years ago

  Heyo,

  Your solution looks good! Few things to note here only:

  1. Setting font-size in px isn't advisable, as it's not accessible (it's not gonna scale if someone were to change their browser's font-size settings). You can set it in rem, I see you're already using it elsewhere ^^

  2. In most cases, setting fixed heights isn't a good idea! Elements have their default height which you can increase by adding padding to them, this will take care of things 95% of the time, I'd say.

  3. Your image should have an alt text. "QR code." would be perfect.

  Everything else is pretty neat, so well done! Happy coding ^^

  0