Qr Code Component

Community feedback

• 

  P

  Gonzalo Tejada•240

  @vgt3j4d4Posted 4 months ago

  • Does the solution include semantic HTML? yes

  • Is it accessible, and what improvements could be made? I see you're using pixels instead of relative units. I believe it would be better using rem/em https://www.freecodecamp.org/news/css-units-when-to-use-each-one/#:~:text=It's%20a%20good%20idea%20to,This%20helps%20with%20accessibility.

  • Does the layout look good on a range of screen sizes? yes

  • Is the code well-structured, readable, and reusable? yes, and since you are using sass, I believe using additional partial files for css reset, variables, etc. will help reusability (although this is pretty simple but I helps for future more complex websites) https://www.w3schools.com/sass/sass_import.php#:~:text=Sass%20Partials,are%20called%20partials%20in%20Sass.

  • Does the solution differ considerably from the design? no

  0