Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr Code Component

P
gajbos99 170

@gajbos99

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

Feeling more comfortable with css.

What challenges did you encounter, and how did you overcome them?

/

What specific areas of your project would you like help with?

/

Community feedback

P

@vgt3j4d4

Posted

  • Does the solution include semantic HTML? yes

  • Is it accessible, and what improvements could be made? I see you're using pixels instead of relative units. I believe it would be better using rem/em https://www.freecodecamp.org/news/css-units-when-to-use-each-one/#:~:text=It's%20a%20good%20idea%20to,This%20helps%20with%20accessibility.

  • Does the layout look good on a range of screen sizes? yes

  • Is the code well-structured, readable, and reusable? yes, and since you are using sass, I believe using additional partial files for css reset, variables, etc. will help reusability (although this is pretty simple but I helps for future more complex websites) https://www.w3schools.com/sass/sass_import.php#:~:text=Sass%20Partials,are%20called%20partials%20in%20Sass.

  • Does the solution differ considerably from the design? no

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord