Static QR component using custom properties

Community feedback

• 

  Marek Witkowski•10

  @mwitkowski96Posted almost 2 years ago

  You have used wrong TAG's.The HTML structure is not best practice.

  Great idea with using variables.

  Grid isn't really needed here. It's better to set font-size: 62.5% it makes fz set to 10px. Easier to modify rems.

  Do not give static sizes to images. Any website should be responsive.

  Good luck with learning.

  Cheers, ~Marek

  0